new error code: TRIO912 unnecessary checkpoints + autofix #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I picked this up and worked on it somewhat recently, but stalled out due to the complexity. The complexity is mostly because it's hard to resist solving the juicy edge cases and autofixing everything, so next time I pick this up I'll just drop the complex parts, see if the basic cases that are working are worth having as a rule, and clean up the PR so it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #70 (merely 5 months after it was opened 😁)
Early WIP, I only got the basic case down.
I started on this before #182, but I'm prioritizing that one.
Remaining TODO:
ifstatementsifis solved this can probably use similar logic, but it'll likely be messy